Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1388943004: Add GCAPI to the GN build. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GCAPI to the GN build. GCAPI is a Windows-specific API for distributors of Chrome. This adds all chrome/installer targets to "gn check" and fixes many associated issues. The result codes targets are also added to "gn check" to make sure people don't accidentally add stuff to those headers. Rather than add a disable for the size_t to int warning for this target, I just fixed the warning and removed the disable flag from GYP. Merged //chrome/common:result_codes into //chrome/common:constants. This is basically a constant and everybody that needed the result codes already depended on the constants target. Fix google_update build file. The midl template already did everything this file was trying to do. I clarified the template documentation a bit. BUG=539428 Committed: https://crrev.com/f986f9572c792346194055784b9237820ffce52b Cr-Commit-Position: refs/heads/master@{#352869}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -38 lines) Patch
M .gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M build/toolchain/win/midl.gni View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_installer.gypi View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/BUILD.gn View 3 chunks +4 lines, -8 lines 0 comments Download
A chrome/installer/gcapi/BUILD.gn View 1 chunk +65 lines, -0 lines 0 comments Download
M chrome/installer/gcapi/gcapi.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/mini_installer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/setup/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 4 chunks +6 lines, -3 lines 0 comments Download
M google_update/BUILD.gn View 1 chunk +1 line, -20 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 2 months ago (2015-10-06 22:36:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388943004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388943004/20001
5 years, 2 months ago (2015-10-06 22:38:51 UTC) #4
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-06 23:59:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388943004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388943004/20001
5 years, 2 months ago (2015-10-07 17:05:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-07 17:18:23 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 17:23:10 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f986f9572c792346194055784b9237820ffce52b
Cr-Commit-Position: refs/heads/master@{#352869}

Powered by Google App Engine
This is Rietveld 408576698