Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8690)

Unified Diff: chrome/installer/util/BUILD.gn

Issue 1388943004: Add GCAPI to the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/BUILD.gn ('k') | google_update/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/BUILD.gn
diff --git a/chrome/installer/util/BUILD.gn b/chrome/installer/util/BUILD.gn
index 7b20c75525b48a26a084169b41f7e3fa33166ca7..f64186c3c914e3bb0f501e1dd19e1e151f01d397 100644
--- a/chrome/installer/util/BUILD.gn
+++ b/chrome/installer/util/BUILD.gn
@@ -10,7 +10,6 @@ static_library("util") {
"//base",
"//chrome:strings",
"//chrome/common:constants",
- "//chrome/common:result_codes",
"//components/variations",
"//content/public/common:result_codes",
]
@@ -58,8 +57,11 @@ static_library("util") {
"user_experiment.cc",
"user_experiment.h",
]
- deps += [
+
+ public_deps = [
":strings",
+ ]
+ deps += [
"//base/third_party/dynamic_annotations",
"//components/metrics",
"//courgette:courgette_lib",
@@ -206,7 +208,7 @@ action("generate_strings") {
# Compile the generated .rc file.
source_set("strings") {
sources = get_target_outputs(":generate_strings")
- deps = [
+ public_deps = [
":generate_strings",
]
}
@@ -268,6 +270,7 @@ if (is_win) {
"//base/test:test_support",
"//chrome:other_version",
"//chrome/common",
+ "//chrome/installer/setup:lib",
"//chrome/installer/test:alternate_version_generator_lib",
"//components/variations",
"//content/public/common",
« no previous file with comments | « chrome/installer/setup/BUILD.gn ('k') | google_update/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698