Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1388913002: Revert of Enable testing of WebRTC IP Permission Finch (Closed)

Created:
5 years, 2 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable testing of WebRTC IP Permission Finch (patchset #1 id:1 of https://codereview.chromium.org/1380893005/ ) Reason for revert: Speculative revert since we see failing tests in the WebRTC waterfall related to ICE. See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/21950 https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/43969 Original issue's description: > Enable testing of WebRTC IP Permission Finch > > BUG=538815 > > Committed: https://crrev.com/efce5aa89bc5ac68f96184e44c4bb4b8c3a985e8 > Cr-Commit-Position: refs/heads/master@{#352420} TBR=brettw@chromium.org,rkaplow@chromium.org,guoweis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=538815 Committed: https://crrev.com/565e0d0173c5fb39441b773052de9f391060258b Cr-Commit-Position: refs/heads/master@{#352570}

Patch Set 1 #

Patch Set 2 : Manual revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 1 chunk +0 lines, -5 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
henrika (OOO until Aug 14)
Created Revert of Enable testing of WebRTC IP Permission Finch
5 years, 2 months ago (2015-10-06 08:40:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388913002/1
5 years, 2 months ago (2015-10-06 08:40:18 UTC) #2
commit-bot: I haz the power
Failed to apply patch for testing/variations/fieldtrial_testing_config_android.json: While running git apply --index -3 -p1; error: patch ...
5 years, 2 months ago (2015-10-06 08:41:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388913002/40002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388913002/40002
5 years, 2 months ago (2015-10-06 09:07:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40002)
5 years, 2 months ago (2015-10-06 09:08:50 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/565e0d0173c5fb39441b773052de9f391060258b Cr-Commit-Position: refs/heads/master@{#352570}
5 years, 2 months ago (2015-10-06 09:09:39 UTC) #9
guoweis_left_chromium
5 years, 2 months ago (2015-10-06 20:58:06 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40002) has been created in
https://codereview.chromium.org/1380323005/ by guoweis@chromium.org.

The reason for reverting is: The original check in broke test and has been fixed
by https://codereview.chromium.org/1381703006
.

Powered by Google App Engine
This is Rietveld 408576698