Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1381703006: Fix a test failure when IP Permission check is turned on (Closed)

Created:
5 years, 2 months ago by guoweis_left_chromium
Modified:
5 years, 2 months ago
Reviewers:
xhwang
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a test failure when IP Permission check is turned on. With IP Permission check, there might not be connectivity as the STUN server is specified but there is no internet connectivity. Add loopback interface to ensure there is always connectivity. BUG=520101 Committed: https://crrev.com/f08e419e94f6d52db5c3bec4b0d5cd29f9901ef4 Cr-Commit-Position: refs/heads/master@{#352657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
guoweis_left_chromium
PTAL.
5 years, 2 months ago (2015-10-06 17:43:57 UTC) #2
guoweis_left_chromium
PTAL.
5 years, 2 months ago (2015-10-06 17:46:34 UTC) #5
xhwang
not super familiar with this code, but it seems to make sense to me. rs ...
5 years, 2 months ago (2015-10-06 17:50:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381703006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381703006/1
5 years, 2 months ago (2015-10-06 17:52:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 19:07:31 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 19:08:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f08e419e94f6d52db5c3bec4b0d5cd29f9901ef4
Cr-Commit-Position: refs/heads/master@{#352657}

Powered by Google App Engine
This is Rietveld 408576698