Fix for forms with more than three address lines getting partially Autofilled

Fix for forms with more than three address lines getting partially Autofilled

With the fix all numbered address lines after line two are ignored (not just the third line); without the fix line four is classified as the start of a billing section and the form is 'split' in two address areas.

The problem can seen on site https://www.southwesttrains.co.uk/register.aspx

BUG=224601
TEST=Manual test; South West Trains site should fully autocomplete (including Post Code field). New unit test FormStructureTest.SurplusAddressLinesIgnored

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195024

[Ilya Sherman, 2013-04-17 05:56:33]

Please also add a regression test for southwesttrains.co.uk under
//chrome/test/data/autofill/heuristics/

https://codereview.chromium.org/13888008/diff/1/components/autofill/browser/a...
File components/autofill/browser/address_field.cc (right):

https://codereview.chromium.org/13888008/diff/1/components/autofill/browser/a...
components/autofill/browser/address_field.cc:234: while (ParseField(scanner,
pattern, NULL));
nit: Please write this as:

pattern = UTF8ToUTF16(autofill::kAddressLinesExtraRe);
while (ParseField(scanner, pattern, NULL)) {
  // Consumed a surplus line, try for another.
}

Among other things, this has the advantage that it doesn't do the UTF conversion
repeatedly.

[Jim Blackler, 2013-04-18 13:49:09]

On 2013/04/17 05:56:33, Ilya Sherman wrote:
> Please also add a regression test for southwesttrains.co.uk under
> //chrome/test/data/autofill/heuristics/
> 
> Done

[Jim Blackler, 2013-04-18 13:49:22]

https://codereview.chromium.org/13888008/diff/1/components/autofill/browser/a...
File components/autofill/browser/address_field.cc (right):

https://codereview.chromium.org/13888008/diff/1/components/autofill/browser/a...
components/autofill/browser/address_field.cc:234: while (ParseField(scanner,
pattern, NULL));
Oh yeah it seems I didn't study that closely what pattern= .... actually did.

[Ilya Sherman, 2013-04-18 16:51:40]

LGTM, thanks :)

[commit-bot: I haz the power, 2013-04-18 20:26:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jimblackler@chromium.org/13888008/14001

[commit-bot: I haz the power, 2013-04-18 22:50:15]

Change committed as 195024