components/autofill/browser/address_field.cc - Issue 13888008: Fix for forms with more than three address lines getting partially Autofilled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/address_field.cc

Issue 13888008: Fix for forms with more than three address lines getting partially Autofilled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review revisions. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/autofill/heuristics/output/17_crbug_224601.out ('k') | components/autofill/browser/autofill_regex_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/address_field.cc

diff --git a/components/autofill/browser/address_field.cc b/components/autofill/browser/address_field.cc

index 037896d0a4450143e55a8de13b6bac2a7c7960c4..e9f0044f94ad0358380b9b51101a6c86739228e8 100644

--- a/components/autofill/browser/address_field.cc

+++ b/components/autofill/browser/address_field.cc

@@ -227,10 +227,12 @@ bool AddressField::ParseAddressLines(AutofillScanner* scanner,

&address_field->address2_);

}

- // Try for a third line, which we will promptly discard.

+ // Try for surplus lines, which we will promptly discard.

if (address_field->address2_ != NULL) {

- pattern = UTF8ToUTF16(autofill::kAddressLine3Re);

- ParseField(scanner, pattern, NULL);

+ pattern = UTF8ToUTF16(autofill::kAddressLinesExtraRe);

+ while (ParseField(scanner, pattern, NULL)) {

+ // Consumed a surplus line, try for another.

+ }

}

return true;