third_party/WebKit/Source/modules/notifications/NotificationData.cpp - Issue 1388483002: Implement the Notification `timestamp` property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

Issue 1388483002: Implement the Notification `timestamp` property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/notifications/notification_data_conversions.cc ('K') | « content/public/common/platform_notification_data.h ('k') | third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp » ('j') | third_party/WebKit/Source/modules/notifications/NotificationOptions.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationData.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

index 865c1a2f9106d952e3f34d977deb587df3730f0f..272d5dff686dc6430896422badffce4c66e7417f 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationData.cpp

@@ -13,6 +13,7 @@

#include "modules/notifications/NotificationOptions.h"

#include "modules/vibration/NavigatorVibration.h"

#include "platform/weborigin/KURL.h"

+#include "wtf/CurrentTime.h"

namespace blink {

namespace {

@@ -56,6 +57,7 @@ WebNotificationData createWebNotificationData(ExecutionContext* executionContext

webData.icon = iconUrl;

webData.vibrate = NavigatorVibration::sanitizeVibrationPattern(options.vibrate());

+ webData.timestamp = options.hasTimestamp() ? static_cast<double>(options.timestamp()) : WTF::currentTimeMS();

webData.silent = options.silent();

webData.requireInteraction = options.requireInteraction();