third_party/WebKit/Source/modules/notifications/NotificationOptions.idl - Issue 1388483002: Implement the Notification `timestamp` property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

Issue 1388483002: Implement the Notification `timestamp` property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/notifications/notification_data_conversions.cc ('K') | « third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp ('k') | third_party/WebKit/public/platform/modules/notifications/WebNotificationData.h » ('j') | third_party/WebKit/public/platform/modules/notifications/WebNotificationData.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl b/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

index 3047c29604b980fc19f3291d53fca0654c859564..f6a7cc86ca8760227b9401660617295226008d43 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

+++ b/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

@@ -18,6 +18,7 @@ dictionary NotificationOptions {

DOMString icon;

// TODO(sh919.park): vibrate should be ([Clamp] unsigned long or sequence<unsigned long>)

(unsigned long or sequence<unsigned long>) vibrate;

+ unsigned long long timestamp;

johnme 2015/10/20 17:12:21 I realise this matches the spec, but I notice that

Peter Beverloo 2016/01/28 17:18:29 Changed to DOMTimeStamp.

boolean silent = false;

boolean requireInteraction = false;

any data = null;