content/child/notifications/notification_data_conversions_unittest.cc - Issue 1388483002: Implement the Notification `timestamp` property

Unified Diff: content/child/notifications/notification_data_conversions_unittest.cc

Issue 1388483002: Implement the Notification `timestamp` property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/child/notifications/notification_data_conversions.cc ('K') | « content/child/notifications/notification_data_conversions.cc ('k') | content/common/platform_notification_messages.h » ('j') | third_party/WebKit/Source/modules/notifications/NotificationOptions.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/notifications/notification_data_conversions_unittest.cc

diff --git a/content/child/notifications/notification_data_conversions_unittest.cc b/content/child/notifications/notification_data_conversions_unittest.cc

index 93e247d197251aac895c58cc298b44cdddad726a..4a3e85e8fb8c51562707224764c168111edc67b6 100644

--- a/content/child/notifications/notification_data_conversions_unittest.cc

+++ b/content/child/notifications/notification_data_conversions_unittest.cc

@@ -22,6 +22,7 @@ const char kNotificationBody[] = "Hello, world!";

const char kNotificationTag[] = "my_tag";

const char kNotificationIconUrl[] = "https://example.com/icon.png";

const int kNotificationVibrationPattern[] = { 100, 200, 300 };

+const double kNotificationTimestamp = 621046800.;

const unsigned char kNotificationData[] = { 0xdf, 0xff, 0x0, 0x0, 0xff, 0xdf };

const char kAction1Name[] = "btn1";

const char kAction1Title[] = "Button 1";

@@ -38,6 +39,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {

web_data.icon = blink::WebURL(GURL(kNotificationIconUrl));

web_data.vibrate = blink::WebVector<int>(

kNotificationVibrationPattern, arraysize(kNotificationVibrationPattern));

+ web_data.timestamp = kNotificationTimestamp;

web_data.silent = true;

web_data.requireInteraction = true;

web_data.data = blink::WebVector<char>(kNotificationData,

@@ -64,6 +66,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {

EXPECT_THAT(platform_data.vibration_pattern,

testing::ElementsAreArray(kNotificationVibrationPattern));

+ EXPECT_DOUBLE_EQ(kNotificationTimestamp, platform_data.timestamp.ToJsTime());

ASSERT_EQ(web_data.data.size(), platform_data.data.size());

for (size_t i = 0; i < web_data.data.size(); ++i)

EXPECT_EQ(web_data.data[i], platform_data.data[i]);

@@ -91,6 +94,7 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {

platform_data.tag = kNotificationTag;

platform_data.icon = GURL(kNotificationIconUrl);

platform_data.vibration_pattern = vibration_pattern;

+ platform_data.timestamp = base::Time::FromJsTime(kNotificationTimestamp);

platform_data.silent = true;

platform_data.require_interaction = true;

platform_data.data = developer_data;

@@ -113,6 +117,7 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {

for (size_t i = 0; i < vibration_pattern.size(); ++i)

EXPECT_EQ(vibration_pattern[i], web_data.vibrate[i]);

+ EXPECT_DOUBLE_EQ(kNotificationTimestamp, web_data.timestamp);

EXPECT_TRUE(web_data.silent);

EXPECT_TRUE(web_data.requireInteraction);