Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1388463002: Rietveld: retry on win on "Errno 10060" socket error. (Closed)

Created:
5 years, 2 months ago by tandrii(chromium)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rietveld: retry on win on "Errno 10060" socket error. R=sergeyberezin@chromium.org BUG=537417 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296995

Patch Set 1 #

Patch Set 2 : I don't know how old code works:( #

Patch Set 3 : #

Patch Set 4 : Structured. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M rietveld.py View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
tandrii(chromium)
PTAL
5 years, 2 months ago (2015-10-02 19:07:16 UTC) #1
tandrii(chromium)
+iannucci@ as trooper
5 years, 2 months ago (2015-10-02 19:13:29 UTC) #3
Sergey Berezin
LGTM. Though string parsing makes me sad... oh well :-)
5 years, 2 months ago (2015-10-02 19:16:16 UTC) #4
iannucci
lgtm ugh. there's not a structured way to catch this exception?
5 years, 2 months ago (2015-10-02 19:17:04 UTC) #5
tandrii(chromium)
On 2015/10/02 19:17:04, iannucci wrote: > lgtm > > ugh. there's not a structured way ...
5 years, 2 months ago (2015-10-02 19:18:33 UTC) #6
tandrii(chromium)
here comes structured approach.
5 years, 2 months ago (2015-10-02 19:29:09 UTC) #7
iannucci
lgtm
5 years, 2 months ago (2015-10-02 19:32:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388463002/60001
5 years, 2 months ago (2015-10-02 19:37:31 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 19:41:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296995

Powered by Google App Engine
This is Rietveld 408576698