Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: rietveld.py

Issue 1388463002: Rietveld: retry on win on "Errno 10060" socket error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Structured. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index 1c569fc9bb1c51a6319cc1caee75f598f161ddce..bf06f31508c6252d8cc0942f2ab2bfd97e82edc5 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -15,10 +15,13 @@ The following hypothesis are made:
"""
import copy
+import errno
import json
import logging
import re
+import socket
import ssl
+import sys
import time
import urllib
import urllib2
@@ -429,7 +432,14 @@ class Rietveld(object):
if retry >= (self._maxtries - 1):
raise
if (not 'Name or service not known' in e.reason and
- not 'EOF occurred in violation of protocol' in e.reason):
+ not 'EOF occurred in violation of protocol' in e.reason and
+ # On windows we hit weird bug http://crbug.com/537417
+ # with message '[Errno 10060] A connection attempt failed...'
+ not (sys.platform.startswith('win') and
+ isinstance(e.reason, socket.error) and
+ e.reason.errno == errno.ETIMEDOUT
+ )
+ ):
# Usually internal GAE flakiness.
raise
except ssl.SSLError, e:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698