Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1388303002: Move assorted function in application_lifetime to where they are used. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move assorted function in application_lifetime to where they are used. BUG=159847 Committed: https://crrev.com/0289786905988c9d37d3cc751e80477ccacad28b Cr-Commit-Position: refs/heads/master@{#353016}

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -56 lines) Patch
M chrome/browser/browser_shutdown.h View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 5 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/lifetime/application_lifetime.cc View 1 2 6 chunks +1 line, -41 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
5 years, 2 months ago (2015-10-07 04:41:04 UTC) #2
sky
LGTM https://codereview.chromium.org/1388303002/diff/1/chrome/browser/browser_shutdown.cc File chrome/browser/browser_shutdown.cc (right): https://codereview.chromium.org/1388303002/diff/1/chrome/browser/browser_shutdown.cc#newcode117 chrome/browser/browser_shutdown.cc:117: browser_shutdown::StartShutdownTracing(); Isn't this code in the browser_shutdown namespace? ...
5 years, 2 months ago (2015-10-07 17:12:33 UTC) #3
Lei Zhang
https://codereview.chromium.org/1388303002/diff/1/chrome/browser/browser_shutdown.cc File chrome/browser/browser_shutdown.cc (right): https://codereview.chromium.org/1388303002/diff/1/chrome/browser/browser_shutdown.cc#newcode117 chrome/browser/browser_shutdown.cc:117: browser_shutdown::StartShutdownTracing(); On 2015/10/07 17:12:32, sky wrote: > Isn't this ...
5 years, 2 months ago (2015-10-08 07:01:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388303002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388303002/40001
5 years, 2 months ago (2015-10-08 07:03:12 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-08 07:39:49 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 07:40:28 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/0289786905988c9d37d3cc751e80477ccacad28b
Cr-Commit-Position: refs/heads/master@{#353016}

Powered by Google App Engine
This is Rietveld 408576698