Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/ui/browser.h

Issue 1388303002: Move assorted function in application_lifetime to where they are used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/lifetime/application_lifetime.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_H_
6 #define CHROME_BROWSER_UI_BROWSER_H_ 6 #define CHROME_BROWSER_UI_BROWSER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 808 matching lines...) Expand 10 before | Expand all | Expand 10 after
819 // the browser. 819 // the browser.
820 bool SupportsWindowFeatureImpl(WindowFeature feature, 820 bool SupportsWindowFeatureImpl(WindowFeature feature,
821 bool check_fullscreen) const; 821 bool check_fullscreen) const;
822 822
823 // Resets |bookmark_bar_state_| based on the active tab. Notifies the 823 // Resets |bookmark_bar_state_| based on the active tab. Notifies the
824 // BrowserWindow if necessary. 824 // BrowserWindow if necessary.
825 void UpdateBookmarkBarState(BookmarkBarStateChangeReason reason); 825 void UpdateBookmarkBarState(BookmarkBarStateChangeReason reason);
826 826
827 bool ShouldHideUIForFullscreen() const; 827 bool ShouldHideUIForFullscreen() const;
828 828
829 // Returns true if we can start the shutdown sequence for the browser, i.e.
830 // the last browser window is being closed.
831 bool ShouldStartShutdown() const;
832
829 // Creates a BackgroundContents if appropriate; return true if one was 833 // Creates a BackgroundContents if appropriate; return true if one was
830 // created. 834 // created.
831 bool MaybeCreateBackgroundContents( 835 bool MaybeCreateBackgroundContents(
832 int route_id, 836 int route_id,
833 int main_frame_route_id, 837 int main_frame_route_id,
834 content::WebContents* opener_web_contents, 838 content::WebContents* opener_web_contents,
835 const std::string& frame_name, 839 const std::string& frame_name,
836 const GURL& target_url, 840 const GURL& target_url,
837 const std::string& partition_id, 841 const std::string& partition_id,
838 content::SessionStorageNamespace* session_storage_namespace); 842 content::SessionStorageNamespace* session_storage_namespace);
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
981 // The following factory is used for chrome update coalescing. 985 // The following factory is used for chrome update coalescing.
982 base::WeakPtrFactory<Browser> chrome_updater_factory_; 986 base::WeakPtrFactory<Browser> chrome_updater_factory_;
983 987
984 // The following factory is used to close the frame at a later time. 988 // The following factory is used to close the frame at a later time.
985 base::WeakPtrFactory<Browser> weak_factory_; 989 base::WeakPtrFactory<Browser> weak_factory_;
986 990
987 DISALLOW_COPY_AND_ASSIGN(Browser); 991 DISALLOW_COPY_AND_ASSIGN(Browser);
988 }; 992 };
989 993
990 #endif // CHROME_BROWSER_UI_BROWSER_H_ 994 #endif // CHROME_BROWSER_UI_BROWSER_H_
OLDNEW
« no previous file with comments | « chrome/browser/lifetime/application_lifetime.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698