Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1388233007: [turbofan] Base JSCreateClosure comparison on location. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Base JSCreateClosure comparison on location. This changes hashing and comparison functions for JSCreateClosure operators to be based in the handle location instead of the referenced object identity. This is in sync with all other JS operators. R=bmeurer@chromium.org Committed: https://crrev.com/b79f397f41f88a3db7413ff8cf822378eb62726f Cr-Commit-Position: refs/heads/master@{#31225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/compiler/js-operator.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-12 13:40:21 UTC) #1
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-10-12 17:54:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388233007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388233007/1
5 years, 2 months ago (2015-10-13 07:42:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 07:43:33 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 07:44:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b79f397f41f88a3db7413ff8cf822378eb62726f
Cr-Commit-Position: refs/heads/master@{#31225}

Powered by Google App Engine
This is Rietveld 408576698