Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: src/compiler/js-operator.cc

Issue 1388233007: [turbofan] Base JSCreateClosure comparison on location. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-operator.cc
diff --git a/src/compiler/js-operator.cc b/src/compiler/js-operator.cc
index 7b1efbf2a7f23f8473c98ead57e219dc09f89f14..5860c925a124c2ad5cb1bcd642ef7183d4ad0c9a 100644
--- a/src/compiler/js-operator.cc
+++ b/src/compiler/js-operator.cc
@@ -423,7 +423,7 @@ const CreateArgumentsParameters& CreateArgumentsParametersOf(
bool operator==(CreateClosureParameters const& lhs,
CreateClosureParameters const& rhs) {
return lhs.pretenure() == rhs.pretenure() &&
- lhs.shared_info().is_identical_to(rhs.shared_info());
+ lhs.shared_info().location() == rhs.shared_info().location();
}
@@ -434,9 +434,7 @@ bool operator!=(CreateClosureParameters const& lhs,
size_t hash_value(CreateClosureParameters const& p) {
- // TODO(mstarzinger): Include hash of the SharedFunctionInfo here.
- base::hash<PretenureFlag> h;
- return h(p.pretenure());
+ return base::hash_combine(p.pretenure(), p.shared_info().location());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698