Issue 13881016: Fix x64 frame size to accomodate saved XMM registers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13881016: Fix x64 frame size to accomodate saved XMM registers (Closed)

Created:
7 years, 8 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 8 months ago

Reviewers:
Michael Starzinger, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix x64 frame size to accomodate saved XMM registers R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14312

Patch Set 1 #

Total comments: 3

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -27 lines)			Patch
	M	src/x64/code-stubs-x64.cc	View		3 chunks	+22 lines, -26 lines	1 comment	Download
	M	src/x64/frames-x64.h	View		1 chunk	+6 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with nits. https://codereview.chromium.org/13881016/diff/1/src/x64/frames-x64.h File src/x64/frames-x64.h (right): https://codereview.chromium.org/13881016/diff/1/src/x64/frames-x64.h#newcode57 src/x64/frames-x64.h:57: kXMMRegisterSize * kCalleeSaveXMMRegisters; nit: Indent by ...

7 years, 8 months ago (2013-04-17 15:33:10 UTC) #2

Dmitry Lomov (no reviews)

Committed patchset #1 manually as r14312 (presubmit successful).

7 years, 8 months ago (2013-04-17 15:36:19 UTC) #3

Jakob Kummerow

7 years, 8 months ago (2013-04-17 16:34:38 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13881016/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

https://codereview.chromium.org/13881016/diff/1/src/x64/code-stubs-x64.cc#new...
src/x64/code-stubs-x64.cc:4410: __ movdqu(xmm8, Operand(rsp,
EntryFrameConstants::kXMMRegisterSize * 3));
DBC: the "8" in this line looks *very* suspicious.

Expand Messages | Collapse Messages