Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: src/x64/frames-x64.h

Issue 13881016: Fix x64 frame size to accomodate saved XMM registers (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/x64/code-stubs-x64.cc ('K') | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved]; 44 typedef Object* JSCallerSavedBuffer[kNumJSCallerSaved];
45 45
46 // Number of registers for which space is reserved in safepoints. 46 // Number of registers for which space is reserved in safepoints.
47 const int kNumSafepointRegisters = 16; 47 const int kNumSafepointRegisters = 16;
48 48
49 // ---------------------------------------------------- 49 // ----------------------------------------------------
50 50
51 class EntryFrameConstants : public AllStatic { 51 class EntryFrameConstants : public AllStatic {
52 public: 52 public:
53 #ifdef _WIN64 53 #ifdef _WIN64
54 static const int kCallerFPOffset = -10 * kPointerSize; 54 static const int kCalleeSaveXMMRegisters = 10;
55 static const int kXMMRegisterSize = 16;
56 static const int kXMMRegistersBlockSize =
57 kXMMRegisterSize * kCalleeSaveXMMRegisters;
Michael Starzinger 2013/04/17 15:33:10 nit: Indent by 4 characters here.
58 static const int kCallerFPOffset =
59 -10 * kPointerSize - kXMMRegistersBlockSize;
Michael Starzinger 2013/04/17 15:33:10 nit: Likewise.
55 #else 60 #else
56 static const int kCallerFPOffset = -8 * kPointerSize; 61 static const int kCallerFPOffset = -8 * kPointerSize;
57 #endif 62 #endif
58 static const int kArgvOffset = 6 * kPointerSize; 63 static const int kArgvOffset = 6 * kPointerSize;
59 }; 64 };
60 65
61 66
62 class ExitFrameConstants : public AllStatic { 67 class ExitFrameConstants : public AllStatic {
63 public: 68 public:
64 static const int kCodeOffset = -2 * kPointerSize; 69 static const int kCodeOffset = -2 * kPointerSize;
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 122
118 123
119 inline Object* JavaScriptFrame::function_slot_object() const { 124 inline Object* JavaScriptFrame::function_slot_object() const {
120 const int offset = JavaScriptFrameConstants::kFunctionOffset; 125 const int offset = JavaScriptFrameConstants::kFunctionOffset;
121 return Memory::Object_at(fp() + offset); 126 return Memory::Object_at(fp() + offset);
122 } 127 }
123 128
124 } } // namespace v8::internal 129 } } // namespace v8::internal
125 130
126 #endif // V8_X64_FRAMES_X64_H_ 131 #endif // V8_X64_FRAMES_X64_H_
OLDNEW
« src/x64/code-stubs-x64.cc ('K') | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698