Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: webkit/appcache/appcache_url_request_job.cc

Issue 13881003: AppCacheExecutableHandlers - parse manifest file and store the 'bit' indicating executable. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_url_request_job.cc
===================================================================
--- webkit/appcache/appcache_url_request_job.cc (revision 194203)
+++ webkit/appcache/appcache_url_request_job.cc (working copy)
@@ -8,6 +8,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
+#include "base/command_line.h"
#include "base/compiler_specific.h"
#include "base/message_loop.h"
#include "base/string_util.h"
@@ -104,6 +105,12 @@
break;
case APPCACHED_DELIVERY:
+ if (entry_.IsExecutable()) {
+ DCHECK(CommandLine::ForCurrentProcess()->HasSwitch(
+ kEnableExecutableHandlers));
+ // TODO(michaeln): do something different here with
alecflett 2013/04/16 22:28:56 perhaps LOG() here? (not sure what the policy is a
michaeln 2013/04/16 22:43:02 should be short-lived that this is empty, afaict a
+ // an AppCacheExecutableHandler.
+ }
AppCacheHistograms::AddAppCacheJobStartDelaySample(
base::TimeTicks::Now() - start_time_tick_);
request()->net_log().AddEvent(

Powered by Google App Engine
This is Rietveld 408576698