AppCacheExecutableHandlers - parse manifest file and store the 'bit' indicating executable.

webkit/appcache/appcache_url_request_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "webkit/appcache/appcache_url_request_job.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
+#include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_log.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_util.h"
 #include "net/url_request/url_request.h"
@@ skipping 76 matching lines @@
     case ERROR_DELIVERY:
       AppCacheHistograms::AddErrorJobStartDelaySample(
           base::TimeTicks::Now() - start_time_tick_);
       request()->net_log().AddEvent(
           net::NetLog::TYPE_APPCACHE_DELIVERING_ERROR_RESPONSE);
       NotifyStartError(net::URLRequestStatus(net::URLRequestStatus::FAILED,
                                              net::ERR_FAILED));
       break;
 
     case APPCACHED_DELIVERY:
+      if (entry_.IsExecutable()) {
+        DCHECK(CommandLine::ForCurrentProcess()->HasSwitch(
+            kEnableExecutableHandlers));
+        // TODO(michaeln): do something different here with

[alecflett, 2013/04/16 22:28:56]

perhaps LOG() here? (not sure what the policy is around logging these days)

[michaeln, 2013/04/16 22:43:02]

should be short-lived that this is empty, afaict also nobody reads that logging
really (wouldn't want to put the extra string data in a real release build
either)

+        // an AppCacheExecutableHandler.
+      }
       AppCacheHistograms::AddAppCacheJobStartDelaySample(
           base::TimeTicks::Now() - start_time_tick_);
       request()->net_log().AddEvent(
           is_fallback_ ?
               net::NetLog::TYPE_APPCACHE_DELIVERING_FALLBACK_RESPONSE :
               net::NetLog::TYPE_APPCACHE_DELIVERING_CACHED_RESPONSE);
       storage_->LoadResponseInfo(
           manifest_url_, group_id_, entry_.response_id(), this);
       break;
 
@@ skipping 177 matching lines @@
     return;
   }
 
   // If multiple ranges are requested, we play dumb and
   // return the entire response with 200 OK.
   if (ranges.size() == 1U)
     range_requested_ = ranges[0];
 }
 
 }  // namespace appcache