Set write buffer flags only in SkWriteBuffer and SkFlatController constructors.

Set write buffer flags only in SkWriteBuffer and SkFlatController constructors.

This is a baby step toward refactored (and faster in-process) typeface and flattenable factory encoding and decoding.  The sooner SkWriteBuffer knows its flags, the better.

Next steps will be to rearrange Sk{Read,Write}Buffer members into disjoint strategies to handle typefaces and flattenable factories: one for in-process, one for cross-process, one when validating.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13253

[mtklein, 2014-01-30 21:11:11]

I am a moron.

[scroggo, 2014-01-30 21:14:13]

lgtm

https://codereview.chromium.org/138803005/diff/20001/src/pipe/SkGPipeWrite.cpp
File src/pipe/SkGPipeWrite.cpp (right):

https://codereview.chromium.org/138803005/diff/20001/src/pipe/SkGPipeWrite.cp...
src/pipe/SkGPipeWrite.cpp:74: : SkFlatController(isCrossProcess ?
SkWriteBuffer::kCrossProcess_Flag : 0)
nit: We should define INHERITED to be SkFlatController, and use it here.

[mtklein, 2014-01-30 21:16:56]

https://codereview.chromium.org/138803005/diff/20001/src/pipe/SkGPipeWrite.cpp
File src/pipe/SkGPipeWrite.cpp (right):

https://codereview.chromium.org/138803005/diff/20001/src/pipe/SkGPipeWrite.cp...
src/pipe/SkGPipeWrite.cpp:74: : SkFlatController(isCrossProcess ?
SkWriteBuffer::kCrossProcess_Flag : 0)
On 2014/01/30 21:14:14, scroggo wrote:
> nit: We should define INHERITED to be SkFlatController, and use it here.

Done.

[scroggo, 2014-01-30 21:17:40]

On 2014/01/30 21:16:56, mtklein wrote:
> https://codereview.chromium.org/138803005/diff/20001/src/pipe/SkGPipeWrite.cpp
> File src/pipe/SkGPipeWrite.cpp (right):
> 
>
https://codereview.chromium.org/138803005/diff/20001/src/pipe/SkGPipeWrite.cp...
> src/pipe/SkGPipeWrite.cpp:74: : SkFlatController(isCrossProcess ?
> SkWriteBuffer::kCrossProcess_Flag : 0)
> On 2014/01/30 21:14:14, scroggo wrote:
> > nit: We should define INHERITED to be SkFlatController, and use it here.
> 
> Done.

lgtm!

[reed1, 2014-01-30 21:29:56]

lgtm

[commit-bot: I haz the power, 2014-01-30 21:30:16]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/138803005/40001

[commit-bot: I haz the power, 2014-01-30 22:16:37]

Change committed as 13253

[commit-bot: I haz the power, 2014-01-30 22:16:41]

CQ bit was unchecked on CL. Ignoring.