src/core/SkFlattenableSerialization.cpp - Issue 138803005: Set write buffer flags only in SkWriteBuffer and SkFlatController constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkFlattenableSerialization.cpp

Issue 138803005: Set write buffer flags only in SkWriteBuffer and SkFlatController constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: INHERITED Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkFlattenableSerialization.cpp

diff --git a/src/core/SkFlattenableSerialization.cpp b/src/core/SkFlattenableSerialization.cpp

index 13fbe6edbf9b0368c13eeb36d67d3c015962a9f9..f34e64170cbb687ec72a3c63049145b237915838 100644

--- a/src/core/SkFlattenableSerialization.cpp

+++ b/src/core/SkFlattenableSerialization.cpp

@@ -12,8 +12,7 @@

#include "SkWriteBuffer.h"

SkData* SkValidatingSerializeFlattenable(SkFlattenable* flattenable) {

- SkWriteBuffer writer;

- writer.setFlags(SkWriteBuffer::kValidation_Flag);

+ SkWriteBuffer writer(SkWriteBuffer::kValidation_Flag);

writer.writeFlattenable(flattenable);

uint32_t size = writer.bytesWritten();

void* data = sk_malloc_throw(size);

« no previous file with comments | « include/core/SkWriteBuffer.h ('k') | src/core/SkPictureFlat.h » ('j') | no next file with comments »