Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 13880009: Include timestamp with vsync-delineating input events (Closed)

Created:
7 years, 8 months ago by Sami
Modified:
7 years, 8 months ago
Reviewers:
jamesr
CC:
blink-reviews, jamesr, abarth_chromum.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Include timestamp with vsync-delineating input events When we receive the final input event for the current vsync interval, tell the input handler about the timestamp of that event. This is needed by the compositor to use the correct animation time for rendering. BUG=230336 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148648

Patch Set 1 #

Patch Set 2 : Document time base. #

Patch Set 3 : Also update the tests. #

Patch Set 4 : Rebased. #

Patch Set 5 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M Source/Platform/chromium/public/WebInputHandlerClient.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Sami
7 years, 8 months ago (2013-04-11 14:03:47 UTC) #1
jamesr
lgtm
7 years, 8 months ago (2013-04-12 03:32:33 UTC) #2
jamesr
Please specify somewhere what "in seconds" means - seconds since what? Is this the same ...
7 years, 8 months ago (2013-04-12 03:33:01 UTC) #3
Sami
On 2013/04/12 03:33:01, jamesr wrote: > Please specify somewhere what "in seconds" means - seconds ...
7 years, 8 months ago (2013-04-12 07:55:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/13880009/4001
7 years, 8 months ago (2013-04-12 07:56:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/13880009/13002
7 years, 8 months ago (2013-04-12 08:48:01 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) test_shell_tests, webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=3566
7 years, 8 months ago (2013-04-12 10:16:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/13880009/21001
7 years, 8 months ago (2013-04-12 13:17:01 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) test_shell_tests, webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=3637
7 years, 8 months ago (2013-04-12 13:48:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/13880009/21001
7 years, 8 months ago (2013-04-12 14:49:31 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=3660
7 years, 8 months ago (2013-04-12 15:19:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/13880009/21001
7 years, 8 months ago (2013-04-12 15:35:33 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=3675
7 years, 8 months ago (2013-04-12 15:55:38 UTC) #13
commit-bot: I haz the power
Failed to apply the patch.
7 years, 8 months ago (2013-04-17 23:31:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/13880009/6003
7 years, 8 months ago (2013-04-18 10:33:26 UTC) #15
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=2376
7 years, 8 months ago (2013-04-18 11:13:22 UTC) #16
Sami
7 years, 8 months ago (2013-04-18 13:25:03 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 manually as r148648 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698