mojo::Serialize*_() calls now propogate/return validation errors.

mojo/public/cpp/bindings/lib/control_message_handler.cc

Index: mojo/public/cpp/bindings/lib/control_message_handler.cc
diff --git a/mojo/public/cpp/bindings/lib/control_message_handler.cc b/mojo/public/cpp/bindings/lib/control_message_handler.cc
index 0c4698273318675b8a6e245073dd61d978b6eac1..5bc5efdb2bdd4ba5ae820f8ff015102aa64665ec 100644
--- a/mojo/public/cpp/bindings/lib/control_message_handler.cc
+++ b/mojo/public/cpp/bindings/lib/control_message_handler.cc
@@ -56,7 +56,8 @@ bool ControlMessageHandler::Run(Message* message,
   ResponseMessageBuilder builder(kRunMessageId, size, message->request_id());
 
   RunResponseMessageParams_Data* response_params = nullptr;
-  Serialize_(response_params_ptr.get(), builder.buffer(), &response_params);
+  MOJO_DCHECK(Serialize_(response_params_ptr.get(), builder.buffer(),

[viettrungluu, 2015/10/09 01:35:19]

This is wrong, since on a non-Debug build Serialize_() won't get called.

Either MOJO_CHECK() it, or do something like:

auto result = Serialize_(...);
MOJO_DCHECK(result == VALIDATION_ERROR_NONE);

[vardhan, 2015/10/09 22:31:28]

cool, i'll do DCHECK the right way :-)

+                         &response_params) == VALIDATION_ERROR_NONE);
   response_params->EncodePointersAndHandles(
       builder.message()->mutable_handles());
   bool ok = responder->Accept(builder.message());