mojo::Serialize*_() calls now propogate/return validation errors.

mojo/public/cpp/bindings/lib/control_message_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/bindings/lib/control_message_handler.h"
 
 #include "mojo/public/cpp/bindings/lib/message_builder.h"
 #include "mojo/public/cpp/environment/logging.h"
 #include "mojo/public/interfaces/bindings/interface_control_messages.mojom.h"
 
@@ skipping 38 matching lines @@
       RunResponseMessageParams::New());
   response_params_ptr->reserved0 = 16u;
   response_params_ptr->reserved1 = 0u;
   response_params_ptr->query_version_result = QueryVersionResult::New();
   response_params_ptr->query_version_result->version = interface_version_;
 
   size_t size = GetSerializedSize_(*response_params_ptr);
   ResponseMessageBuilder builder(kRunMessageId, size, message->request_id());
 
   RunResponseMessageParams_Data* response_params = nullptr;
-  Serialize_(response_params_ptr.get(), builder.buffer(), &response_params);
+  MOJO_DCHECK(Serialize_(response_params_ptr.get(), builder.buffer(),

[viettrungluu, 2015/10/09 01:35:19]

This is wrong, since on a non-Debug build Serialize_() won't get called.

Either MOJO_CHECK() it, or do something like:

auto result = Serialize_(...);
MOJO_DCHECK(result == VALIDATION_ERROR_NONE);

[vardhan, 2015/10/09 22:31:28]

cool, i'll do DCHECK the right way :-)

+                         &response_params) == VALIDATION_ERROR_NONE);
   response_params->EncodePointersAndHandles(
       builder.message()->mutable_handles());
   bool ok = responder->Accept(builder.message());
   MOJO_ALLOW_UNUSED_LOCAL(ok);
   delete responder;
 
   return true;
 }
 
 bool ControlMessageHandler::RunOrClosePipe(Message* message) {
   RunOrClosePipeMessageParams_Data* params =
       reinterpret_cast<RunOrClosePipeMessageParams_Data*>(
           message->mutable_payload());
   params->DecodePointersAndHandles(message->mutable_handles());
 
   RunOrClosePipeMessageParamsPtr params_ptr(RunOrClosePipeMessageParams::New());
   Deserialize_(params, params_ptr.get());
 
   return interface_version_ >= params_ptr->require_version->version;
 }
 
 }  // namespace internal
 }  // namespace mojo