mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl - Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl

Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Cleaned up how serialization errors propagate, and addressed other comments from viettrungluu@ Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/lib/map_serialization.h ('K') | « mojo/public/tools/bindings/generators/cpp_templates/struct_serialization_definition.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl

index 588e749d70ac1739052b1d8f9dddb5d45ea5f92a..d29a356670bc6f57aad8cf75a5a29f5ae2ea2e62 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl

@@ -1,5 +1,7 @@

size_t GetSerializedSize_(const {{union.name}}Ptr& input, bool inlined);

-void SerializeUnion_({{union.name}}* input, mojo::internal::Buffer* buffer,

- internal::{{union.name}}_Data** output, bool inlined);

+mojo::internal::ValidationError SerializeUnion_(

+ {{union.name}}* input,

+ mojo::internal::Buffer* buffer,

+ internal::{{union.name}}_Data** output, bool inlined);

void Deserialize_(internal::{{union.name}}_Data* input,

{{union.name}}* output);