mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl - Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl

Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Cleaned up how serialization errors propagate, and addressed other comments from viettrungluu@ Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 size_t GetSerializedSize_(const {{union.name}}Ptr& input, bool inlined);	1 size_t GetSerializedSize_(const {{union.name}}Ptr& input, bool inlined);

2 void SerializeUnion_({{union.name}}* input, mojo::internal::Buffer* buffer,	2 mojo::internal::ValidationError SerializeUnion_(

3 internal::{{union.name}}_Data** output, bool inlined);	3 {{union.name}}* input,

	4 mojo::internal::Buffer* buffer,

	5 internal::{{union.name}}_Data** output, bool inlined);

4 void Deserialize_(internal::{{union.name}}_Data* input,	6 void Deserialize_(internal::{{union.name}}_Data* input,

5 {{union.name}}* output);	7 {{union.name}}* output);

OLD	NEW