third_party/WebKit/PerformanceTests/Canvas/createImageBitmapFromImageData.html - Issue 1387933002: Adding performance benchmark for creating imagebitmap from imagedata

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/PerformanceTests/Canvas/createImageBitmapFromImageData.html

Issue 1387933002: Adding performance benchmark for creating imagebitmap from imagedata (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/runner.js"></script>

	5 <script>

	6 var imgHeight = 1024;

	7 var imgWidth = 1024;

	8 var canvas = document.createElement("canvas");

	9 canvas.width = imgWidth;

	10 canvas.height = imgHeight;

	11 var context = canvas.getContext('2d');

	12 var image = context.createImageData(imgWidth, imgHeight);

	13

	14 function rand(range) {

	15 return Math.floor(Math.random() * range);

	16 }

	17

	18 function setImageData() {
	Justin Novosad 2015/10/06 02:17:53 I would call this initializeImageData. I would call this initializeImageData.
	19 for(var i = 0; i < image.data.length; i+= 4)
	Justin Novosad 2015/10/06 02:17:53 if you just incremented i by 1, you would not need if you just incremented i by 1, you would not need two nested loops.
	20 for(var j = 0; j < 4; j++)

	21 image.data[i+j] = rand(255);
	Justin Novosad 2015/10/06 02:17:52 Not that it matters much, but to produce values be Not that it matters much, but to produce values between 0 and 255 uniformly, you should call rand(256). Look it up: Math.random() produces value in the range [0,1)
	22 }

	23

	24 function imageBitmapFromImageData() {

	25 createImageBitmap(image, 0, 0, imgWidth, imgHeight);
	Justin Novosad 2015/10/06 02:17:53 Add a comment to explain that the return Promise i Add a comment to explain that the return Promise is not retained because this test is meant to only measure the immediate run time of createImageBitmap from an ImageData, which is not to be implemented in a way that does all the work synchronously, even though the API is technically async.
	26 }

	27

	28 setImageData();

	29 PerfTestRunner.measureRunsPerSecond({run: imageBitmapFromImageData, description: "This bench test checks the speed on creating ImageBitmap from ImageData(1024x1 024)."});

	30 </script>

	31 </body>

	32 </html>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »