LayoutObject::invalidatePaintIfNeededForSynchronizedPainting() and plumbing

LayoutObject::invalidatePaintIfNeededForSynchronizedPainting() and plumbing

Follow-ups:
- Create real PaintInvalidationState during painting;
- Call the new method during painting.

BUG=536999
Committed: https://crrev.com/3ef2644f5b822155c2eb7edff674f73840253282
Cr-Commit-Position: refs/heads/master@{#352688}

[Xianzhu, 2015-10-05 19:33:12]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2015-10-05 21:50:35]

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1428: // TODO(chrishtr):
paintInvalidationContainer for squashed layer.
This works out of the box. GraphicsLayer::paint calls into CLM::doPaintTask,
which
will loop over the paint layers and paint them.

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.h:1234: void
invalidatePaintIfNeeded(const PaintInfo& paintInfo) {
m_layoutObject.invalidatePaintIfNeededForSynchronziedPainting(paintInfo); }
typo: synchronized

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
(left):

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp:164:
ASSERT(!item.isCached() || item.client() != client.displayItemClient());
Why remove these asserts?

[Xianzhu, 2015-10-05 22:04:16]

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:1428: // TODO(chrishtr):
paintInvalidationContainer for squashed layer.
On 2015/10/05 21:50:35, chrishtr wrote:
> This works out of the box. GraphicsLayer::paint calls into CLM::doPaintTask,
> which
> will loop over the paint layers and paint them.

Done.

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.h:1234: void
invalidatePaintIfNeeded(const PaintInfo& paintInfo) {
m_layoutObject.invalidatePaintIfNeededForSynchronziedPainting(paintInfo); }
On 2015/10/05 21:50:35, chrishtr wrote:
> typo: synchronized

Done.

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
(left):

https://codereview.chromium.org/1387923002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp:164:
ASSERT(!item.isCached() || item.client() != client.displayItemClient());
On 2015/10/05 21:50:35, chrishtr wrote:
> Why remove these asserts?

Now this method calls invalidateUntracked(). The assert in invalidateUntracked()
has the same purpose.

[chrishtr, 2015-10-05 22:08:08]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-10-05 22:08:08]

lgtm

[commit-bot: I haz the power, 2015-10-05 22:09:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1387923002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1387923002/100001

[commit-bot: I haz the power, 2015-10-05 23:31:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 23:31:26]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2015-10-06 18:55:54]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2015-10-06 18:55:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1387923002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-10-06 18:56:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1387923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1387923002/120001

[commit-bot: I haz the power, 2015-10-06 21:24:35]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-10-06 21:25:30]

Patchset 7 (id:??) landed as
https://crrev.com/3ef2644f5b822155c2eb7edff674f73840253282
Cr-Commit-Position: refs/heads/master@{#352688}