third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h - Issue 1387743002: Fixed expando-loss.html test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

Issue 1387743002: Fixed expando-loss.html test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cache ScriptState and use it to wrap m_defaultVertexArrayObject. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('K') | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

index 8a9b164bae1e62c787ecbf41e5451f303b043a98..4ceea3cf332a75c4c23342594ff31db3dfdd8653 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.h

@@ -42,7 +42,7 @@ public:

Factory() {}

~Factory() override {}

- PassOwnPtrWillBeRawPtr<CanvasRenderingContext> create(HTMLCanvasElement*, const CanvasContextCreationAttributes&, Document&) override;

+ PassOwnPtrWillBeRawPtr<CanvasRenderingContext> create(HTMLCanvasElement*, ScriptState*, const CanvasContextCreationAttributes&, Document&) override;

CanvasRenderingContext::ContextType contextType() const override { return CanvasRenderingContext::ContextWebgl; }

void onError(HTMLCanvasElement*, const String& error) override;

};

@@ -58,7 +58,7 @@ public:

DECLARE_VIRTUAL_TRACE();

private:

- WebGLRenderingContext(HTMLCanvasElement*, PassOwnPtr<WebGraphicsContext3D>, const WebGLContextAttributes&);

+ WebGLRenderingContext(HTMLCanvasElement*, ScriptState*, PassOwnPtr<WebGraphicsContext3D>, const WebGLContextAttributes&);

// Enabled extension objects.

PersistentWillBeMember<ANGLEInstancedArrays> m_angleInstancedArrays;