third_party/WebKit/Source/modules/imagebitmap/ImageBitmapModuleTest.cpp - Issue 1387743002: Fixed expando-loss.html test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/imagebitmap/ImageBitmapModuleTest.cpp

Issue 1387743002: Fixed expando-loss.html test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cache ScriptState and use it to wrap m_defaultVertexArrayObject. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp ('k') | third_party/WebKit/Source/modules/webgl/OESVertexArrayObject.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/imagebitmap/ImageBitmapModuleTest.cpp

diff --git a/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapModuleTest.cpp b/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapModuleTest.cpp

index 325fdddc99227377a3d916d4fbdeb988296c3580..2513da1beeb30671aa502bd9d78609ed32d19dfc 100644

--- a/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapModuleTest.cpp

+++ b/third_party/WebKit/Source/modules/imagebitmap/ImageBitmapModuleTest.cpp

@@ -48,7 +48,7 @@ TEST_F(ImageBitmapModuleTest, ImageResourceLifetime)

imageBitmapDerived = ImageBitmap::create(imageBitmapFromCanvas.get(), IntRect(0, 0, 20, 20));

}

CanvasContextCreationAttributes attributes;

- CanvasRenderingContext2D* context = static_cast<CanvasRenderingContext2D*>(canvasElement->getCanvasRenderingContext("2d", attributes));

+ CanvasRenderingContext2D* context = static_cast<CanvasRenderingContext2D*>(canvasElement->getCanvasRenderingContext(nullptr, "2d", attributes));

TrackExceptionState exceptionState;

CanvasImageSourceUnion imageSource;

imageSource.setImageBitmap(imageBitmapDerived);