third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp - Issue 1387743002: Fixed expando-loss.html test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

Issue 1387743002: Fixed expando-loss.html test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cache ScriptState and use it to wrap m_defaultVertexArrayObject. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/canvas/CanvasFontCacheTest.cpp ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

index 48eeb0c2ff23f861597c0939dc803a738f35cb9c..07ce378dc7c9873e26d1a58ede7eab9d7e38af89 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp

@@ -62,7 +62,7 @@ void CanvasRenderingContext2DAPITest::createContext(OpacityMode opacityMode)

String canvasType("2d");

CanvasContextCreationAttributes attributes;

attributes.setAlpha(opacityMode == NonOpaque);

- m_canvasElement->getCanvasRenderingContext(canvasType, attributes);

+ m_canvasElement->getCanvasRenderingContext(nullptr, canvasType, attributes);

haraken 2015/10/13 02:02:04 Ditto.

context2d(); // Calling this for the checks

}

@@ -250,7 +250,7 @@ void resetCanvasForAccessibilityRectTest(HTMLDocument& document)

String canvasType("2d");

CanvasContextCreationAttributes attributes;

attributes.setAlpha(true);

- canvas->getCanvasRenderingContext(canvasType, attributes);

+ canvas->getCanvasRenderingContext(nullptr, canvasType, attributes);

EXPECT_NE(nullptr, canvas->renderingContext());

EXPECT_TRUE(canvas->renderingContext()->is2d());