Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2160)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 138763009: Fix (or tag) uses of explicit '64' instead of GL_MAILBOX_SIZE_CHROMIUM (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 6911f280af418e8603273583f65ce2c0d6ef1fa7..344b1e8245976ce9e8f7c99846ad828b183a4a5c 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -841,7 +841,9 @@ scoped_ptr<cc::CompositorFrame> MakeGLFrame(float scale_factor,
frame->metadata.device_scale_factor = scale_factor;
frame->gl_frame_data.reset(new cc::GLFrameData);
frame->gl_frame_data->sync_point = 1;
- memset(frame->gl_frame_data->mailbox.name, '1', 64);
+ memset(frame->gl_frame_data->mailbox.name,
+ '1',
+ sizeof(frame->gl_frame_data->mailbox.name));
danakj 2014/02/13 17:59:25 sizeof(mailbox.name) here again
frame->gl_frame_data->size = size;
frame->gl_frame_data->sub_buffer_rect = damage;
return frame.Pass();
@@ -949,7 +951,7 @@ TEST_F(RenderWidgetHostViewAuraTest, SwapNotifiesWindow) {
GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params params;
params.surface_id = widget_host_->surface_id();
params.route_id = widget_host_->GetRoutingID();
- params.mailbox_name = std::string(64, '1');
+ memset(params.mailbox.name, '1', sizeof(params.mailbox.name));
params.size = view_size;
params.scale_factor = 1.f;
@@ -968,7 +970,7 @@ TEST_F(RenderWidgetHostViewAuraTest, SwapNotifiesWindow) {
GpuHostMsg_AcceleratedSurfacePostSubBuffer_Params post_params;
post_params.surface_id = widget_host_->surface_id();
post_params.route_id = widget_host_->GetRoutingID();
- post_params.mailbox_name = std::string(64, '1');
+ memset(post_params.mailbox.name, '1', sizeof(post_params.mailbox.name));
post_params.surface_size = gfx::Size(200, 200);
post_params.surface_scale_factor = 2.f;
post_params.x = 40;

Powered by Google App Engine
This is Rietveld 408576698