Fix (or tag) uses of explicit '64' instead of GL_MAILBOX_SIZE_CHROMIUM

content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/basictypes.h"
 #include "base/memory/shared_memory.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
@@ skipping 823 matching lines @@
   EXPECT_EQ(0, cursor_client.calls_to_set_cursor());
 }
 
 scoped_ptr<cc::CompositorFrame> MakeGLFrame(float scale_factor,
                                             gfx::Size size,
                                             gfx::Rect damage) {
   scoped_ptr<cc::CompositorFrame> frame(new cc::CompositorFrame);
   frame->metadata.device_scale_factor = scale_factor;
   frame->gl_frame_data.reset(new cc::GLFrameData);
   frame->gl_frame_data->sync_point = 1;
-  memset(frame->gl_frame_data->mailbox.name, '1', 64);
+  memset(frame->gl_frame_data->mailbox.name,
+         '1',
+         sizeof(frame->gl_frame_data->mailbox.name));

[danakj, 2014/02/13 17:59:25]

sizeof(mailbox.name) here again

   frame->gl_frame_data->size = size;
   frame->gl_frame_data->sub_buffer_rect = damage;
   return frame.Pass();
 }
 
 scoped_ptr<cc::CompositorFrame> MakeSoftwareFrame(float scale_factor,
                                                   gfx::Size size,
                                                   gfx::Rect damage) {
   scoped_ptr<cc::CompositorFrame> frame(new cc::CompositorFrame);
   frame->metadata.device_scale_factor = scale_factor;
@@ skipping 87 matching lines @@
   view_->SetSize(view_size);
   view_->WasShown();
 
   MockWindowObserver observer;
   view_->window_->AddObserver(&observer);
 
   // Swap a frame through the GPU path.
   GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params params;
   params.surface_id = widget_host_->surface_id();
   params.route_id = widget_host_->GetRoutingID();
-  params.mailbox_name = std::string(64, '1');
+  memset(params.mailbox.name, '1', sizeof(params.mailbox.name));
   params.size = view_size;
   params.scale_factor = 1.f;
 
   EXPECT_CALL(observer, OnWindowPaintScheduled(view_->window_, view_rect));
   view_->AcceleratedSurfaceBuffersSwapped(params, 0);
   testing::Mock::VerifyAndClearExpectations(&observer);
 
   // DSF = 2
   params.size = gfx::Size(200, 200);
   params.scale_factor = 2.f;
   EXPECT_CALL(observer, OnWindowPaintScheduled(view_->window_, view_rect));
   view_->AcceleratedSurfaceBuffersSwapped(params, 0);
   testing::Mock::VerifyAndClearExpectations(&observer);
 
   // Partial frames though GPU path
   GpuHostMsg_AcceleratedSurfacePostSubBuffer_Params post_params;
   post_params.surface_id = widget_host_->surface_id();
   post_params.route_id = widget_host_->GetRoutingID();
-  post_params.mailbox_name = std::string(64, '1');
+  memset(post_params.mailbox.name, '1', sizeof(post_params.mailbox.name));
   post_params.surface_size = gfx::Size(200, 200);
   post_params.surface_scale_factor = 2.f;
   post_params.x = 40;
   post_params.y = 40;
   post_params.width = 80;
   post_params.height = 80;
   // rect from params is upside down, and is inflated in RWHVA, just because.
   EXPECT_CALL(observer, OnWindowPaintScheduled(view_->window_,
                                                gfx::Rect(19, 39, 42, 42)));
   view_->AcceleratedSurfacePostSubBuffer(post_params, 0);
@@ skipping 431 matching lines @@
 
   // Because the copy request callback may be holding state within it, that
   // state must handle the RWHVA and ImageTransportFactory going away before the
   // callback is called. This test passes if it does not crash as a result of
   // these things being destroyed.
   EXPECT_EQ(2, callback_count_);
   EXPECT_FALSE(result_);
 }
 
 }  // namespace content