Issue 1387563004: Revert of Fixed WebGL printing crash due to failed buffer allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1387563004: Revert of Fixed WebGL printing crash due to failed buffer allocation (Closed)

Created:
5 years, 2 months ago by dmurph

Modified:
5 years, 2 months ago

Reviewers:
Ken Russell (switch to Gerrit), Justin Novosad

CC:
chromium-reviews, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Fixed WebGL printing crash due to failed buffer allocation (patchset #2 id:20001 of https://codereview.chromium.org/1380633003/ ) Reason for revert: BUG=538697 Failing OOM on Windows 7 bots Original issue's description: > Fixed WebGL printing crash due to failed buffer allocation > > BUG=537711 > R=kbr@chromium.org > > Committed: https://crrev.com/dda8a88830593f605501500c4de9c870e70c94eb > Cr-Commit-Position: refs/heads/master@{#351790} TBR=kbr@chromium.org,junov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=537711 Committed: https://crrev.com/1631ec9bbd55e355549d27e308860ad93eb75345 Cr-Commit-Position: refs/heads/master@{#352084}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -36 lines)			Patch
D	third_party/WebKit/LayoutTests/printing/webgl-oversized-printing.html	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	third_party/WebKit/LayoutTests/printing/webgl-oversized-printing-expected.txt	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmurph

Created Revert of Fixed WebGL printing crash due to failed buffer allocation

5 years, 2 months ago (2015-10-02 18:31:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387563004/1

5 years, 2 months ago (2015-10-02 18:33:53 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-02 18:39:15 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1631ec9bbd55e355549d27e308860ad93eb75345
Cr-Commit-Position: refs/heads/master@{#352084}

Expand Messages | Collapse Messages