Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1387563002: Revert "Stage sloppy block-scoped functions (Annex B 3.3)" (Closed)

Created:
5 years, 2 months ago by Michael Hablich
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.7
Target Ref:
refs/pending/branch-heads/4.7
Project:
v8
Visibility:
Public.

Description

Revert "Stage sloppy block-scoped functions (Annex B 3.3)" The current implemention breaks sloppy mode code that uses function declarations inside blocks at top-level. Work is ongoing on a patch to fix this issue, but in the meantime it seems reasonable to move the feature out of staging. Manual revert of commit 6e07f5a75ba2c949ac96efabd5248c76b9957112. Cherry-picked of bab3b5508280e7a58720f701f9dbec96f81a16d8 TBR=littledan@chromium.org,adamk@chromium.org BUG=chromium:535836 LOG=y Review URL: https://codereview.chromium.org/1375213005 Cr-Commit-Position: refs/heads/master@{#31029} Committed: https://chromium.googlesource.com/v8/v8/+/5e8d5de29948e1692cac630d4169a137fd7897d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M src/flag-definitions.h View 2 chunks +11 lines, -11 lines 0 comments Download
M test/test262/test262.status View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Michael Hablich
On 2015/10/02 12:33:27, Hablich wrote: > mailto:hablich@chromium.org changed reviewers: > + mailto:adamk@chromium.org This is not ...
5 years, 2 months ago (2015-10-02 12:34:05 UTC) #2
Michael Hablich
5 years, 2 months ago (2015-10-02 12:34:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e8d5de29948e1692cac630d4169a137fd7897d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698