Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 1375213005: Revert "Stage sloppy block-scoped functions (Annex B 3.3)" (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Stage sloppy block-scoped functions (Annex B 3.3)" The current implemention breaks sloppy mode code that uses function declarations inside blocks at top-level. Work is ongoing on a patch to fix this issue, but in the meantime it seems reasonable to move the feature out of staging. Manual revert of commit 6e07f5a75ba2c949ac96efabd5248c76b9957112. R=littledan@chromium.org BUG=chromium:535836 LOG=y Committed: https://crrev.com/bab3b5508280e7a58720f701f9dbec96f81a16d8 Cr-Commit-Position: refs/heads/master@{#31029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M src/flag-definitions.h View 2 chunks +11 lines, -11 lines 0 comments Download
M test/test262/test262.status View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
adamk
5 years, 2 months ago (2015-09-30 18:52:20 UTC) #1
Dan Ehrenberg
lgtm
5 years, 2 months ago (2015-09-30 18:53:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375213005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375213005/1
5 years, 2 months ago (2015-09-30 18:53:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 19:17:30 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 19:17:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bab3b5508280e7a58720f701f9dbec96f81a16d8
Cr-Commit-Position: refs/heads/master@{#31029}

Powered by Google App Engine
This is Rietveld 408576698