Cast: IPC glue between cast library transport and encoders.

chrome/renderer/media/cast_transport_sender_ipc.h

Index: chrome/renderer/media/cast_transport_sender_ipc.h
diff --git a/chrome/renderer/media/cast_transport_sender_ipc.h b/chrome/renderer/media/cast_transport_sender_ipc.h
new file mode 100644
index 0000000000000000000000000000000000000000..955059e0eb6f00fc54772ab8ee860bc73a83994c
--- /dev/null
+++ b/chrome/renderer/media/cast_transport_sender_ipc.h
@@ -0,0 +1,19 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.

[acolwell GONE FROM CHROMIUM, 2014/02/11 00:57:38]

nit: s/(c) 2013/2014/

[hubbe, 2014/02/12 00:54:24]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_RENDERER_MEDIA_CAST_TRANSPORT_SENDER_IPC_H_
+#define CHROME_RENDERER_MEDIA_CAST_TRANSPORT_SENDER_IPC_H_
+
+#include "base/message_loop/message_loop_proxy.h"
+#include "ipc/ipc_channel_proxy.h"
+#include "media/cast/transport/cast_transport_sender.h"
+
+media::cast::transport::CastTransportSender* NewCastTransportSenderIPC(

[acolwell GONE FROM CHROMIUM, 2014/02/11 00:57:38]

There is only one implementation for each of these factory methods which calls
into question their utility. Please change the code to use constructors on the
actual objects instead of hiding behind these method signatures. You can always
add factory methods when there is more than one implementation.

[hubbe, 2014/02/12 00:54:24]

The point of using factory method is to speed up compilation.
Anyways, I've changed it use more common chrome parlance.
In conjunction with removing the friendships, I now have to write each
method name 4 times. But it should look like chrome code now.

+    const media::cast::transport::CastTransportConfig& config,
+    const media::cast::transport::CastTransportStatusCallback& status_cb);
+
+scoped_refptr<IPC::ChannelProxy::MessageFilter> NewCastIPCDispatcher(
+    const scoped_refptr<base::MessageLoopProxy>& io_message_loop);
+
+#endif  // CHROME_RENDERER_MEDIA_CAST_TRANSPORT_SENDER_IPC_H_