chrome/renderer/media/cast_transport_sender_ipc.h - Issue 138753004: Cast: IPC glue between cast library transport and encoders.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/media/cast_transport_sender_ipc.h

Issue 138753004: Cast: IPC glue between cast library transport and encoders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sorted deps Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/media/cast_session_delegate.cc ('K') | « chrome/renderer/media/cast_session_delegate.cc ('k') | chrome/renderer/media/cast_transport_sender_ipc.cc » ('j') | chrome/renderer/media/cast_transport_sender_ipc.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	acolwell GONE FROM CHROMIUM 2014/02/11 00:57:38 nit: s/(c) 2013/2014/ nit: s/(c) 2013/2014/ hubbe 2014/02/12 00:54:24 Done. Show quoted text On 2014/02/11 00:57:38, acolwell wrote: > nit: s/(c) 2013/2014/ Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_RENDERER_MEDIA_CAST_TRANSPORT_SENDER_IPC_H_

	6 #define CHROME_RENDERER_MEDIA_CAST_TRANSPORT_SENDER_IPC_H_

	7

	8 #include "base/message_loop/message_loop_proxy.h"

	9 #include "ipc/ipc_channel_proxy.h"

	10 #include "media/cast/transport/cast_transport_sender.h"

	11

	12 media::cast::transport::CastTransportSender* NewCastTransportSenderIPC(
	acolwell GONE FROM CHROMIUM 2014/02/11 00:57:38 There is only one implementation for each of these There is only one implementation for each of these factory methods which calls into question their utility. Please change the code to use constructors on the actual objects instead of hiding behind these method signatures. You can always add factory methods when there is more than one implementation. hubbe 2014/02/12 00:54:24 The point of using factory method is to speed up c Show quoted text On 2014/02/11 00:57:38, acolwell wrote: > There is only one implementation for each of these factory methods which calls > into question their utility. Please change the code to use constructors on the > actual objects instead of hiding behind these method signatures. You can always > add factory methods when there is more than one implementation. The point of using factory method is to speed up compilation. Anyways, I've changed it use more common chrome parlance. In conjunction with removing the friendships, I now have to write each method name 4 times. But it should look like chrome code now.
	13 const media::cast::transport::CastTransportConfig& config,

	14 const media::cast::transport::CastTransportStatusCallback& status_cb);

	15

	16 scoped_refptr<IPC::ChannelProxy::MessageFilter> NewCastIPCDispatcher(

	17 const scoped_refptr<base::MessageLoopProxy>& io_message_loop);

	18

	19 #endif // CHROME_RENDERER_MEDIA_CAST_TRANSPORT_SENDER_IPC_H_

OLD	NEW