Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1387483006: Revert of [Tracing] Add allocation register for heap profiling (Closed)

Created:
5 years, 2 months ago by kuan
Modified:
5 years, 2 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@backtrace
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Tracing] Add allocation register for heap profiling (patchset #7 id:120001 of https://codereview.chromium.org/1371053002/ ) Reason for revert: broke builds: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/94444/steps/compile/logs/stdio https://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/37877/steps/compile/logs/stdio Original issue's description: > [Tracing] Add allocation register for heap profiling > > Malloc and PartitionAlloc dumpers will use this allocation register (a > hash table) to keep track of all outstanding allocations. The hash table > is tailored for this purpose. It handles its own memory management, to > avoid allocation reentrancy issues when doing the bookkeeping. This is > part of the heap profiler in chrome://tracing. > > BUG=524631 > > Committed: https://crrev.com/fd577b4f6c1f24709c274d8970d4f8e6369bb1ff > Cr-Commit-Position: refs/heads/master@{#352664} TBR=primiano@chromium.org,ruuda@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=524631 Committed: https://crrev.com/1cd5fee938b55399ff68538699e453c110021d8c Cr-Commit-Position: refs/heads/master@{#352685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -684 lines) Patch
M base/trace_event/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D base/trace_event/memory_profiler_allocation_register.h View 1 chunk +0 lines, -159 lines 0 comments Download
D base/trace_event/memory_profiler_allocation_register.cc View 1 chunk +0 lines, -166 lines 0 comments Download
D base/trace_event/memory_profiler_allocation_register_posix.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D base/trace_event/memory_profiler_allocation_register_unittest.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D base/trace_event/memory_profiler_allocation_register_win.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M base/trace_event/trace_event.gypi View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kuan
Created Revert of [Tracing] Add allocation register for heap profiling
5 years, 2 months ago (2015-10-06 21:02:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387483006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387483006/1
5 years, 2 months ago (2015-10-06 21:04:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 21:08:58 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 21:11:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cd5fee938b55399ff68538699e453c110021d8c
Cr-Commit-Position: refs/heads/master@{#352685}

Powered by Google App Engine
This is Rietveld 408576698