Switch HTML5 Fullscreen Over to AppKit

chrome/browser/ui/cocoa/browser_window_controller.mm

Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index c4205301f799e87d52ba2ceacf4e8451191d9afc..42fd0f810777e44521b04bcee855d0df0c1e56ce 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1966,7 +1966,11 @@ willAnimateFromState:(BookmarkBar::State)oldState
 
 - (void)enterWebContentFullscreenForURL:(const GURL&)url
                              bubbleType:(ExclusiveAccessBubbleType)bubbleType {
-  [self enterImmersiveFullscreen];
+  if (chrome::mac::SupportsSystemFullscreen() && base::mac::IsOSLionOrLater())
+    [self exitAppKitFullscreen];

[erikchen, 2015/10/07 21:51:03]

I'm confused - should this be enterAppKitFullscreen?

Also, is this going to have the write sliding style?

[spqchan, 2015/10/07 22:54:01]

Whoops, yes this should be enterAppKitFullscreen 
(Fyi, enterAppKitFullscreen and exitAppKitFullscreen have the same
implementation so there's no need to make any further changes)

Also, yes this will have the right sliding style. See
adjustUIForEnteringFullscreen

[erikchen, 2015/10/07 23:17:53]

adjustUIForEnteringFullscreen relies on enteringPresentationMode_ to get the
right style, but that variable isn't set to YES here. 

[spqchan, 2015/10/07 23:53:26]

In adjustUIForEnteringFullscreen, we check if the fullscreen is for tab content
(which includes HTML5):
if (browser_->exclusive_access_manager()
          ->fullscreen_controller()
          ->IsWindowFullscreenForTabOrPending()) {
    style = fullscreen_mac::OMNIBOX_TABS_NONE;
}

+  else
+    [self enterImmersiveFullscreen];
+
   if (!url.is_empty())
     [self updateFullscreenExitBubbleURL:url bubbleType:bubbleType];
 }