Switch HTML5 Fullscreen Over to AppKit

chrome/browser/ui/cocoa/browser_window_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 #include <cmath>
 #include <numeric>
 
 #include "base/command_line.h"
@@ skipping 1948 matching lines @@
     [self enterBrowserFullscreenWithToolbar:NO];
   } else {
     [self enterImmersiveFullscreen];
     DCHECK(!url.is_empty());
     [self updateFullscreenExitBubbleURL:url bubbleType:bubbleType];
   }
 }
 
 - (void)enterWebContentFullscreenForURL:(const GURL&)url
                              bubbleType:(ExclusiveAccessBubbleType)bubbleType {
-  [self enterImmersiveFullscreen];
+  if (chrome::mac::SupportsSystemFullscreen() && base::mac::IsOSLionOrLater())
+    [self exitAppKitFullscreen];

[erikchen, 2015/10/07 21:51:03]

I'm confused - should this be enterAppKitFullscreen?

Also, is this going to have the write sliding style?

[spqchan, 2015/10/07 22:54:01]

Whoops, yes this should be enterAppKitFullscreen 
(Fyi, enterAppKitFullscreen and exitAppKitFullscreen have the same
implementation so there's no need to make any further changes)

Also, yes this will have the right sliding style. See
adjustUIForEnteringFullscreen

[erikchen, 2015/10/07 23:17:53]

adjustUIForEnteringFullscreen relies on enteringPresentationMode_ to get the
right style, but that variable isn't set to YES here. 

[spqchan, 2015/10/07 23:53:26]

In adjustUIForEnteringFullscreen, we check if the fullscreen is for tab content
(which includes HTML5):
if (browser_->exclusive_access_manager()
          ->fullscreen_controller()
          ->IsWindowFullscreenForTabOrPending()) {
    style = fullscreen_mac::OMNIBOX_TABS_NONE;
}

+  else
+    [self enterImmersiveFullscreen];
+
   if (!url.is_empty())
     [self updateFullscreenExitBubbleURL:url bubbleType:bubbleType];
 }
 
 - (void)exitAnyFullscreen {
   // TODO(erikchen): Fullscreen modes should stack. Should be able to exit
   // Immersive Fullscreen and still be in AppKit Fullscreen.
   if ([self isInAppKitFullscreen])
     [self exitAppKitFullscreen];
   if ([self isInImmersiveFullscreen])
@@ skipping 81 matching lines @@
 
 - (BOOL)supportsBookmarkBar {
   return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
 }
 
 - (BOOL)isTabbedWindow {
   return browser_->is_type_tabbed();
 }
 
 @end  // @implementation BrowserWindowController(WindowType)