Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl

Issue 1387453002: Sync the DeviceOrientation and DeviceMotion interfaces with the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl
diff --git a/third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl b/third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl
index 15130d8473301ba5e0d538361252b2f7f2223392..8046ef162c186497dfb0e90be6f9193417abcd32 100644
--- a/third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl
+++ b/third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl
@@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+// TODO(philipj): The event listener attributes are not in the spec's IDL:
+// https://github.com/w3c/deviceorientation/issues/17
timvolodine 2015/10/02 11:47:17 do we need this comment here? looks like we should
philipj_slow 2015/10/02 12:37:53 I generally add TODOs for everything that is not p
timvolodine 2015/10/02 17:50:28 In my view a TODO usually implies that something h
+
[
ImplementedAs=DOMWindowDeviceMotion
] partial interface Window {

Powered by Google App Engine
This is Rietveld 408576698