third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl - Issue 1387453002: Sync the DeviceOrientation and DeviceMotion interfaces with the spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl

Issue 1387453002: Sync the DeviceOrientation and DeviceMotion interfaces with the spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl ('K') | « third_party/WebKit/Source/modules/device_orientation/DeviceRotationRate.idl ('k') | third_party/WebKit/Source/modules/device_orientation/WindowDeviceOrientation.idl » ('j') | third_party/WebKit/Source/modules/device_orientation/WindowDeviceOrientation.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 // TODO(philipj): The event listener attributes are not in the spec's IDL:

	6 // https://github.com/w3c/deviceorientation/issues/17
	timvolodine 2015/10/02 11:47:17 do we need this comment here? looks like we should do we need this comment here? looks like we should update the spec instead.. philipj_slow 2015/10/02 12:37:53 I generally add TODOs for everything that is not p Show quoted text On 2015/10/02 11:47:17, timvolodine wrote: > do we need this comment here? looks like we should update the spec instead.. I generally add TODOs for everything that is not per spec, and then remove the TODOs if the spec is fixed, which sometimes results in some other change that I had imagined. Not much room for variation here, but there will be a link to the partial interface. timvolodine 2015/10/02 17:50:28 In my view a TODO usually implies that something h Show quoted text On 2015/10/02 12:37:53, philipj wrote: > On 2015/10/02 11:47:17, timvolodine wrote: > > do we need this comment here? looks like we should update the spec instead.. > > I generally add TODOs for everything that is not per spec, and then remove the > TODOs if the spec is fixed, which sometimes results in some other change that I > had imagined. Not much room for variation here, but there will be a link to the > partial interface. In my view a TODO usually implies that something has to be done in the current (or related) code.. This issue seems relate to the spec itself, there is nothing wrong with this file is there?
	7

5 [	8 [

6 ImplementedAs=DOMWindowDeviceMotion	9 ImplementedAs=DOMWindowDeviceMotion

7 ] partial interface Window {	10 ] partial interface Window {

8 attribute EventHandler ondevicemotion;	11 attribute EventHandler ondevicemotion;

9 };	12 };

OLD	NEW