Sync the DeviceOrientation and DeviceMotion interfaces with the spec

Sync the DeviceOrientation and DeviceMotion interfaces with the spec

http://w3c.github.io/deviceorientation/spec-source-orientation.html

Ther are no changes to the generated code, as a nullable readonly
attribute is handled by bindings just like a non-nullable one.

BUG=460722
R=timvolodine@chromium.org

Committed: https://crrev.com/612459487662eacb45ee820fa49290d34f8e2bdd
Cr-Commit-Position: refs/heads/master@{#353253}

[philipj_slow, 2015-10-01 19:42:08]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 19:42:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1387453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1387453002/1

[commit-bot: I haz the power, 2015-10-01 21:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 21:19:31]

Dry run: This issue passed the CQ dry run.

[philipj_slow, 2015-10-02 09:08:36]

The bots are happy, PTAL :)

[timvolodine, 2015-10-02 11:47:17]

thanks for looking into this philipj@, few comments below

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl
(right):

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/device_orientation/DeviceOrientationEvent.idl:28:
// TODO(philipj): DeviceMotionEvent should have a constructor.
-> DeviceOrientationEvent

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl
(right):

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl:6:
// https://github.com/w3c/deviceorientation/issues/17
do we need this comment here? looks like we should update the spec instead..

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/device_orientation/WindowDeviceOrientation.idl
(right):

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/device_orientation/WindowDeviceOrientation.idl:6:
// https://github.com/w3c/deviceorientation/issues/17
same here

[philipj_slow, 2015-10-02 12:37:53]

If you don't like the spec bug link I can remove it and come back to this once
the spec is updated.

Also, can I put your name on the TODOs? You are the module owner, and I'm just
trying to document where our IDL doesn't match the specs :)

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl
(right):

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl:6:
// https://github.com/w3c/deviceorientation/issues/17
On 2015/10/02 11:47:17, timvolodine wrote:
> do we need this comment here? looks like we should update the spec instead..

I generally add TODOs for everything that is not per spec, and then remove the
TODOs if the spec is fixed, which sometimes results in some other change that I
had imagined. Not much room for variation here, but there will be a link to the
partial interface.

[timvolodine, 2015-10-02 17:50:28]

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl
(right):

https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl:6:
// https://github.com/w3c/deviceorientation/issues/17
On 2015/10/02 12:37:53, philipj wrote:
> On 2015/10/02 11:47:17, timvolodine wrote:
> > do we need this comment here? looks like we should update the spec instead..
> 
> I generally add TODOs for everything that is not per spec, and then remove the
> TODOs if the spec is fixed, which sometimes results in some other change that
I
> had imagined. Not much room for variation here, but there will be a link to
the
> partial interface.

In my view a TODO usually implies that something has to be done in the current
(or related) code.. This issue seems relate to the spec itself, there is nothing
wrong with this file is there?

[timvolodine, 2015-10-02 17:51:29]

On 2015/10/02 12:37:53, philipj wrote:
> If you don't like the spec bug link I can remove it and come back to this once
> the spec is updated.
> 
> Also, can I put your name on the TODOs? You are the module owner, and I'm just
> trying to document where our IDL doesn't match the specs :)

I am fine with somebody else looking into it ;)

> 
>
https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
> File
third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl
> (right):
> 
>
https://codereview.chromium.org/1387453002/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl:6:
> // https://github.com/w3c/deviceorientation/issues/17
> On 2015/10/02 11:47:17, timvolodine wrote:
> > do we need this comment here? looks like we should update the spec instead..
> 
> I generally add TODOs for everything that is not per spec, and then remove the
> TODOs if the spec is fixed, which sometimes results in some other change that
I
> had imagined. Not much room for variation here, but there will be a link to
the
> partial interface.

[philipj_slow, 2015-10-05 08:40:14]

OK, I've just linked to the spec bug without a TODO, and left the other TODOs in
my name. PTAL :)

[timvolodine, 2015-10-06 18:22:07]

thanks, apart from two comments looks ok to me ;)

https://codereview.chromium.org/1387453002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl
(right):

https://codereview.chromium.org/1387453002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/device_orientation/WindowDeviceMotion.idl:5:
// The event listener attributes are not in the spec's IDL:
I think this doesn't carry any information regarding this file. Just remove?

https://codereview.chromium.org/1387453002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/device_orientation/WindowDeviceOrientation.idl
(right):

https://codereview.chromium.org/1387453002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/device_orientation/WindowDeviceOrientation.idl:5:
// The event listener attributes are not in the spec's IDL:
remove?

[philipj_slow, 2015-10-08 14:57:39]

Very well, I have removed the spec bug links, I'll instead track the discrepency
using the fact that these files don't have a spec URL in them.

[timvolodine, 2015-10-08 16:25:18]

On 2015/10/08 14:57:39, philipj wrote:
> Very well, I have removed the spec bug links, I'll instead track the
discrepency
> using the fact that these files don't have a spec URL in them.

Thanks! It's just that we should either fix the spec or put a todo to fix the
Window* files. The spec does mention 'deviceorientation' event firing on Window
so that is kind of implicitly there (if that is what you meant by the comments).

[timvolodine, 2015-10-08 16:25:26]

lgtm

[philipj_slow, 2015-10-09 08:39:22]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-10-09 08:39:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1387453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1387453002/60001

[commit-bot: I haz the power, 2015-10-09 09:53:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-09 09:54:26]

Patchset 4 (id:??) landed as
https://crrev.com/612459487662eacb45ee820fa49290d34f8e2bdd
Cr-Commit-Position: refs/heads/master@{#353253}

[philipj_slow, 2015-10-09 15:00:34]

On 2015/10/08 16:25:18, timvolodine wrote:
> On 2015/10/08 14:57:39, philipj wrote:
> > Very well, I have removed the spec bug links, I'll instead track the
> discrepency
> > using the fact that these files don't have a spec URL in them.
> 
> Thanks! It's just that we should either fix the spec or put a todo to fix the
> Window* files. The spec does mention 'deviceorientation' event firing on
Window
> so that is kind of implicitly there (if that is what you meant by the
comments).

Right, it's the spec that should be fixed, I'm just in the habit of documenting
all differences with no attempt to differentiate between the trivial and the
tricky.