Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 138743008: Make sure the root node of selector queries is a ContainerNode (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
esprehn, adamk, eseidel
CC:
blink-reviews, caseq+blink_chromium.org, alph+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make sure the root node of selector queries is a ContainerNode Make sure the root node of selector queries is a ContainerNode by moving the querySelector*() methods from the Node class to the ContainerNode class. These methods are exposed to JS on Document and Element, both of which are container nodes. Doing this gets rid of an unnecessary container node check in SelectorQuery and also enables using the slightly faster firstWithin(ContainerNode) over firstWithin(Node) traversal method. R=eseidel, esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165783

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -68 lines) Patch
M Source/core/dom/ContainerNode.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 2 chunks +27 lines, -0 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 2 chunks +0 lines, -27 lines 0 comments Download
M Source/core/dom/SelectorQuery.h View 1 2 4 chunks +14 lines, -13 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 1 2 15 chunks +18 lines, -18 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebNode.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
6 years, 11 months ago (2014-01-17 19:36:17 UTC) #1
Inactive
I rebased the patch. Any opinion on this patch? This is similar to my other ...
6 years, 11 months ago (2014-01-22 15:10:03 UTC) #2
Inactive
+adamk
6 years, 11 months ago (2014-01-24 02:50:03 UTC) #3
esprehn
rsgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
6 years, 11 months ago (2014-01-24 03:04:10 UTC) #4
Inactive
On 2014/01/24 03:04:10, esprehn wrote: > rsgtm > > To unsubscribe from this group and ...
6 years, 11 months ago (2014-01-24 14:04:02 UTC) #5
esprehn
rslgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
6 years, 11 months ago (2014-01-24 16:25:01 UTC) #6
adamk
lgtm for Source/web/
6 years, 11 months ago (2014-01-24 20:01:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/138743008/160001
6 years, 11 months ago (2014-01-24 20:02:06 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 22:20:53 UTC) #9
Message was sent while issue was closed.
Change committed as 165783

Powered by Google App Engine
This is Rietveld 408576698