Source/web/WebNode.cpp - Issue 138743008: Make sure the root node of selector queries is a ContainerNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebNode.cpp

Issue 138743008: Make sure the root node of selector queries is a ContainerNode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebNode.cpp

diff --git a/Source/web/WebNode.cpp b/Source/web/WebNode.cpp

index eb249b32815ff9cc5847005780d31d46ff9f4c16..d069fbd48f24f35d334d96567f414ee45dc28a16 100644

--- a/Source/web/WebNode.cpp

+++ b/Source/web/WebNode.cpp

@@ -201,7 +201,9 @@ WebNodeList WebNode::getElementsByTagName(const WebString& tag) const

WebElement WebNode::querySelector(const WebString& tag, WebExceptionCode& ec) const

{

TrackExceptionState exceptionState;

- WebElement element(m_private->querySelector(tag, exceptionState));

+ WebElement element;

+ if (m_private->isContainerNode())

+ element = toContainerNode(m_private.get())->querySelector(tag, exceptionState);

ec = exceptionState.code();

return element;

}

« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/web/tests/TouchActionTest.cpp » ('j') | no next file with comments »