build/config/nacl/BUILD.gn - Issue 1387253005: GN: Don't pass -integrated-as to pnacl-clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/nacl/BUILD.gn

Issue 1387253005: GN: Don't pass -integrated-as to pnacl-clang (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/nacl/BUILD.gn

diff --git a/build/config/nacl/BUILD.gn b/build/config/nacl/BUILD.gn

index dcd736fe3346a6cd272dd9cd18337693d20b60f4..51ebabd79a385eb7a5b688a7d9e3386a5b632121 100644

--- a/build/config/nacl/BUILD.gn

+++ b/build/config/nacl/BUILD.gn

@@ -39,7 +39,7 @@ config("compiler") {

configs = []

cflags = []

- if (is_clang) {

+ if (is_clang && current_cpu != "pnacl") {

# -no-integrated-as is the default in nacl-clang for historical

# compatibility with inline assembly code and so forth. But there

# are no such cases in Chromium code, and -integrated-as is nicer in

« no previous file with comments | « no previous file | no next file » | no next file with comments »