Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: build/config/nacl/BUILD.gn

Issue 1387253005: GN: Don't pass -integrated-as to pnacl-clang (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The Native Client Authors. All rights reserved. 1 # Copyright (c) 2014 The Native Client Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/nacl/config.gni") 5 import("//build/config/nacl/config.gni")
6 6
7 # Native Client Definitions 7 # Native Client Definitions
8 config("nacl_defines") { 8 config("nacl_defines") {
9 defines = [ 9 defines = [
10 "_DEFAULT_SOURCE=1", 10 "_DEFAULT_SOURCE=1",
(...skipping 21 matching lines...) Expand all
32 public_configs = [ ":nacl_defines" ] 32 public_configs = [ ":nacl_defines" ]
33 if (current_os == "nacl") { 33 if (current_os == "nacl") {
34 public_configs += [ ":nexe_defines" ] 34 public_configs += [ ":nexe_defines" ]
35 } 35 }
36 } 36 }
37 37
38 config("compiler") { 38 config("compiler") {
39 configs = [] 39 configs = []
40 cflags = [] 40 cflags = []
41 41
42 if (is_clang) { 42 if (is_clang && current_cpu != "pnacl") {
43 # -no-integrated-as is the default in nacl-clang for historical 43 # -no-integrated-as is the default in nacl-clang for historical
44 # compatibility with inline assembly code and so forth. But there 44 # compatibility with inline assembly code and so forth. But there
45 # are no such cases in Chromium code, and -integrated-as is nicer in 45 # are no such cases in Chromium code, and -integrated-as is nicer in
46 # general. Moreover, the IRT must be built using LLVM's assembler 46 # general. Moreover, the IRT must be built using LLVM's assembler
47 # on x86-64 to preserve sandbox base address hiding. Use it 47 # on x86-64 to preserve sandbox base address hiding. Use it
48 # everywhere for consistency (and possibly quicker builds). 48 # everywhere for consistency (and possibly quicker builds).
49 cflags += [ "-integrated-as" ] 49 cflags += [ "-integrated-as" ]
50 } 50 }
51 51
52 asmflags = cflags 52 asmflags = cflags
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 "-Os", 86 "-Os",
87 87
88 # These are omitted from non-IRT libraries to keep the libraries 88 # These are omitted from non-IRT libraries to keep the libraries
89 # themselves small. 89 # themselves small.
90 "-ffunction-sections", 90 "-ffunction-sections",
91 "-fdata-sections", 91 "-fdata-sections",
92 ] 92 ]
93 93
94 ldflags = [ "-Wl,--gc-sections" ] 94 ldflags = [ "-Wl,--gc-sections" ]
95 } 95 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698