Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1387253005: GN: Don't pass -integrated-as to pnacl-clang (Closed)

Created:
5 years, 2 months ago by Roland McGrath
Modified:
5 years, 2 months ago
CC:
chromium-reviews, Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Don't pass -integrated-as to pnacl-clang The -integrated-as switch is desireable for nacl-clang, but it is meaningless for (and not accepted by) pnacl-clang. So don't treat the pnacl case the same as the nacl-clang case. BUG=531702 R=dpranke@chromium.org, dschuff@chromium.org Committed: https://crrev.com/8c3671cfb041b9874af8faea6061338c774d2bc3 Cr-Commit-Position: refs/heads/master@{#353467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/nacl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Roland McGrath
5 years, 2 months ago (2015-10-09 23:43:14 UTC) #1
Roland McGrath
dpranke: Please hit the CQ when giving this OWNERS LGTM.
5 years, 2 months ago (2015-10-09 23:44:34 UTC) #2
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-10 18:30:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387253005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387253005/1
5 years, 2 months ago (2015-10-10 18:30:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-10 18:58:40 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-10 18:59:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c3671cfb041b9874af8faea6061338c774d2bc3
Cr-Commit-Position: refs/heads/master@{#353467}

Powered by Google App Engine
This is Rietveld 408576698