Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 13872010: cros: Add a header for gaia auth requests. (Closed)

Created:
7 years, 8 months ago by xiyuan
Modified:
7 years, 5 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

cros: Add a header for gaia auth requests. - Add background handler to gaia auth to add a http header "X-Origin: Cros-Auth-Ext" for all requests in gaia sub frame; - Load gaia auth extension on web ui login creation and unload it when the login view is gone; BUG=230415

Patch Set 1 #

Total comments: 5

Patch Set 2 : rebase, comments in #1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -34 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.h View 3 chunks +7 lines, -0 lines 1 comment Download
M chrome/browser/chromeos/login/webui_login_view.cc View 6 chunks +53 lines, -1 line 4 comments Download
M chrome/browser/extensions/component_loader.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/gaia_auth/background.js View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/resources/gaia_auth/main.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/gaia_auth/manifest.json View 1 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/resources/gaia_auth/manifest_test.json View 1 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
asargent please review extensions/* zel please review all files
7 years, 8 months ago (2013-04-11 19:50:39 UTC) #1
zel
https://codereview.chromium.org/13872010/diff/1/chrome/browser/resources/gaia_auth/manifest.json File chrome/browser/resources/gaia_auth/manifest.json (right): https://codereview.chromium.org/13872010/diff/1/chrome/browser/resources/gaia_auth/manifest.json#newcode29 chrome/browser/resources/gaia_auth/manifest.json:29: "<all_urls>" Can't we scope this down from <all_urls>? This ...
7 years, 8 months ago (2013-04-11 20:43:20 UTC) #2
asargent_no_longer_on_chrome
https://codereview.chromium.org/13872010/diff/1/chrome/browser/resources/gaia_auth/manifest.json File chrome/browser/resources/gaia_auth/manifest.json (right): https://codereview.chromium.org/13872010/diff/1/chrome/browser/resources/gaia_auth/manifest.json#newcode7 chrome/browser/resources/gaia_auth/manifest.json:7: "content_security_policy": "default-src 'self'; script-src 'self'; frame-src *; style-src 'self' ...
7 years, 8 months ago (2013-04-12 17:46:06 UTC) #3
xiyuan
Permissions issue is still under discussion. Will ping back once it is settled. https://codereview.chromium.org/13872010/diff/1/chrome/browser/resources/gaia_auth/manifest.json File ...
7 years, 8 months ago (2013-04-12 18:05:00 UTC) #4
Nikita (slow)
https://codereview.chromium.org/13872010/diff/5001/chrome/browser/chromeos/login/webui_login_view.cc File chrome/browser/chromeos/login/webui_login_view.cc (right): https://codereview.chromium.org/13872010/diff/5001/chrome/browser/chromeos/login/webui_login_view.cc#newcode203 chrome/browser/chromeos/login/webui_login_view.cc:203: Profile* profile = ProfileManager::GetDefaultProfile(); Depending on which CL lands ...
7 years, 8 months ago (2013-04-15 15:49:26 UTC) #5
Nikita (slow)
7 years, 8 months ago (2013-04-19 11:35:57 UTC) #6
https://codereview.chromium.org/13872010/diff/5001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/webui_login_view.cc (right):

https://codereview.chromium.org/13872010/diff/5001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/webui_login_view.cc:152:
component_loader->Add(IDR_GAIA_AUTH_MANIFEST,
Is ComponentLoader just fine with postponed initialization?

https://codereview.chromium.org/13872010/diff/5001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/webui_login_view.cc:161: Profile* profile_;
nit: // Not owned.

https://codereview.chromium.org/13872010/diff/5001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/webui_login_view.cc:203: Profile* profile =
ProfileManager::GetDefaultProfile();
On 2013/04/15 15:49:27, Nikita Kostylev wrote:
> Depending on which CL lands first, this has to be merged with
> https://codereview.chromium.org/13633003/

CL landed, this should be ProfileHelper::GetSigninProfile() now.

https://codereview.chromium.org/13872010/diff/5001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/webui_login_view.h (right):

https://codereview.chromium.org/13872010/diff/5001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/webui_login_view.h:165:
scoped_ptr<ScopedGaiaAuthExtension> gaia_auth_;
nit: gaia_auth_ext_

Powered by Google App Engine
This is Rietveld 408576698